[Freeipa-devel] PATCH: fixes LDAP driver searches

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/03/2009 01:44 PM, Simo Sorce wrote:
> On Mon, 2009-08-03 at 13:34 -0400, Stephen Gallagher wrote:
>> On 08/03/2009 01:18 PM, Simo Sorce wrote:
>>> Stupid typo was making all searches just vanish in thin air.
>>> Should work fine with this patch.
> 
>> Nack.
>>
>> You're testing if(ret==EOK) below the switch statement, but it's not
>> initialized, and it's only set for
>>     case LDAP_RES_BIND:
>>     case LDAP_RES_SEARCH_RESULT:
>>     case LDAP_RES_MODIFY:
>>     case LDAP_RES_ADD:
>>     case LDAP_RES_DELETE:
>>     case LDAP_RES_MODDN:
>>     case LDAP_RES_COMPARE:
>>     case LDAP_RES_EXTENDED:
>>     case LDAP_RES_INTERMEDIATE:
> 
> Right, that check is actually not really needed anymore.
> Attached patch that changes the code so that the useless check is
> removed.
> 
> Simo.
> 
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel

Ack and pushed to master.

- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkp3JIMACgkQeiVVYja6o6OZ2gCfUjXDB7qJTwqSLmQ6HZbDiczM
4fsAoKiS1pvS76ItQCFNl3Hu17NlKIPb
=m1Dm
-----END PGP SIGNATURE-----