[Freeipa-devel] [PATCH] 074 Automember UI - default groups

[Endi Sukma Dewata]

  On 2/2/2012 11:13 AM, Petr Vobornik wrote:
> In this patch was implemented and added a control for defining default
> automember groups.
>
> There is a difference from UXD spec. In the spec the control was placed
> below table in the search facet. This was not working well with the
> combobox in the control. Open combobox requires some space below it. As
> it was placed at the bottom of the page it created unwanted blank space
> and forced showing scrollbars. Moving the control above the table solves
> the problem without rewriting combobox logic. It can be rewritten and
> moved down later.
>
> https://fedorahosted.org/freeipa/ticket/2195

Issues that need fixing:

1. When default user group is enabled, selecting the drop down list to 
empty will generate an error: 'automemberdefaultgroup' is required. If 
you click Cancel the UI will show empty value but the default user group 
is actually still set on the server. I think when you select empty value 
the UI should call automember-default-group-remove.

2. When default user group is disabled, clicking enable then disable 
will generate an error: No default group set. Having a checked checkbox 
with no selected value in the drop down list is actually equivalent to 
having an unchecked checkbox. So I think the checkbox is redundant and 
can be removed. We can disable the default user group by selecting an 
empty value as in #1.

Issues that probably need further discussion:

3. The position of the default user/host group interface seems to be 
inconsistent with the rest of the UI. The behavior is also different, 
when you change the value it updates the server immediately without 
clicking any Update button. In my opinion it would be better to move it 
into a separate facet. So when you open the User Group Rules you'll see 
two tabs, one for the Rules (default), and the other for Settings. The 
Settings will have a field with a drop down list for the default user 
group. Any changes will have to be saved by clicking the Update button.

4. We also have a 'Default users group' in IPA Server -> Configuration. 
This could be confusing. We probably need to use more descriptive 
labels. Or maybe remove the one under IPA Server from the UI if this is 
considered a system settings.

5. The server uses the same automemberdefaultgroup attribute to store 
the default group DN and the error message "No default group set". To 
distinguish the result the UI (and possibly other applications using the 
JSON RPC) will have to use a non-standard way such as checking whether 
the attribute starts with a 'cn='. I think if there's no default group 
the server should not return this attribute at all and return the 
message in a separate error attribute.

-- 
Endi S. Dewata