[Freeipa-devel] [PATCH] 074 Automember UI - default groups

[Petr Vobornik]

Updated patch attached.

On 02/04/2012 01:27 AM, Endi Sukma Dewata wrote:
> On 2/2/2012 11:13 AM, Petr Vobornik wrote:
>>...
>> https://fedorahosted.org/freeipa/ticket/2195
>
> Issues that need fixing:
>
> 1. When default user group is enabled, selecting the drop down list to
> empty will generate an error: 'automemberdefaultgroup' is required. If
> you click Cancel the UI will show empty value but the default user group
> is actually still set on the server. I think when you select empty value
> the UI should call automember-default-group-remove.
>
> 2. When default user group is disabled, clicking enable then disable
> will generate an error: No default group set. Having a checked checkbox
> with no selected value in the drop down list is actually equivalent to
> having an unchecked checkbox. So I think the checkbox is redundant and
> can be removed. We can disable the default user group by selecting an
> empty value as in #1.

#1 #2: Removed 'enable checkbox'. Seems less error prone. The question 
is: Is it sufficiently clear?


>
> Issues that probably need further discussion:
>
> 3. The position of the default user/host group interface seems to be
> inconsistent with the rest of the UI. The behavior is also different,
> when you change the value it updates the server immediately without
> clicking any Update button. In my opinion it would be better to move it
> into a separate facet. So when you open the User Group Rules you'll see
> two tabs, one for the Rules (default), and the other for Settings. The
> Settings will have a field with a drop down list for the default user
> group. Any changes will have to be saved by clicking the Update button.

I agree on the part that it is inconsistent with the rest of the UI and 
user is not properly informed that the changes are immediately executed.

Nevertheless I wouldn't move it to other facet. It seems to me as too 
much clicking if you want to just check the default group.

I can imagine this improvement: if a command is successfully executed it 
would show on the right of the combobox a message saying: "default group 
set" or "default group removed". The message can have style as the 
message used in adder dialog (after "add and add another"). The message 
would fade out after couple (5?) seconds.

>
> 4. We also have a 'Default users group' in IPA Server -> Configuration.
> This could be confusing. We probably need to use more descriptive
> labels. Or maybe remove the one under IPA Server from the UI if this is
> considered a system settings.
>

New user is added to both group (config and automember default) so the 
label is OK - it does what it says.  I would remove it from the UI only 
if it would be removed from config plugin.


> 5. The server uses the same automemberdefaultgroup attribute to store
> the default group DN and the error message "No default group set". To
> distinguish the result the UI (and possibly other applications using the
> JSON RPC) will have to use a non-standard way such as checking whether
> the attribute starts with a 'cn='. I think if there's no default group
> the server should not return this attribute at all and return the
> message in a separate error attribute.
>

Yes it is inconsistent with the rest of the API. Agree on the empty 
part. Not having set default group is not an error so the message 
shouldn't be in error attribute. From UI perspective the message is not 
needed but I think CLI is using it.

In general I don't like automember plugin - too inconsistent, incomplete 
metadata, unusable labels.


-- 
Petr Vobornik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0074-1-Automember-UI-default-groups.patch
Type: text/x-patch
Size: 13496 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120206/a6ab0205/attachment.bin>