[Freeipa-devel] [PATCH] 216 Remove memberPrincipal for deleted replicas

[Martin Kosek]

On Fri, 2012-03-02 at 09:39 -0500, Simo Sorce wrote:
> On Fri, 2012-03-02 at 12:34 +0100, Martin Kosek wrote:
> > +                principals.remove(member_principal)
> > +                mod = [(ldap.MOD_REPLACE, 'memberPrincipal',
> > principals)] 
> 
> Any special reason why you use a search and then a replace instead of a
> delete by value ?
> 
> A delete by value seem a lot less error prone to me, and should give you
> the same resuls.
> 
> Simo.
> 

Hm, thanks, that's a good point and much better approach. Updated patch
is attached.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkosek-216-2-remove-memberprincipal-for-deleted-replicas.patch
Type: text/x-patch
Size: 3202 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120302/204eb85d/attachment.bin>