[Freeipa-devel] [PATCH] 216 Remove memberPrincipal for deleted replicas

[Simo Sorce]

On Fri, 2012-03-02 at 16:22 +0100, Martin Kosek wrote:
> On Fri, 2012-03-02 at 09:39 -0500, Simo Sorce wrote:
> > On Fri, 2012-03-02 at 12:34 +0100, Martin Kosek wrote:
> > > +                principals.remove(member_principal)
> > > +                mod = [(ldap.MOD_REPLACE, 'memberPrincipal',
> > > principals)] 
> > 
> > Any special reason why you use a search and then a replace instead of a
> > delete by value ?
> > 
> > A delete by value seem a lot less error prone to me, and should give you
> > the same resuls.
> > 
> > Simo.
> > 
> 
> Hm, thanks, that's a good point and much better approach. Updated patch
> is attached.

Ack.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York