[Freeipa-devel] [PATCH 66] Replace broken i18n shell test with Python test

[John Dennis]

On 03/26/2012 04:24 AM, Petr Viktorin wrote:
> Great! Just two issues now.
>
> According to the style guide, we do allow %s in a string iff it only
> appears once. The reason for named substitutions is that the word order
> can be changed, providing context is just secondary.
> Why does the checker report messages with a single %s as errors?

Good catch, I should have known better, I believe I was the one who 
wrote that section in the style guide, so I should have known better (or 
remembered better). Fixed.

> You've removed test_lang from Makefile.in, but test and .PHONY still
> mention it.

Also fixed.

Updated patch attached.

-- 
John Dennis <jdennis at redhat.com>

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jdennis-0066-3-Replace-broken-i18n-shell-test-with-Python-test.patch
Type: text/x-patch
Size: 32666 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120326/1f8218d7/attachment.bin>