[Freeipa-devel] [PATCH] 70 Parse zone indices in IPv6 addresses in CheckedIPAddress

[Jan Cholasta]

On 27.3.2012 10:43, Martin Kosek wrote:
> On Mon, 2012-03-19 at 14:02 +0100, Jan Cholasta wrote:
>> https://fedorahosted.org/freeipa/ticket/2138
>>
>> Honza
>>
>
> This will work, I just think that a documentation of this issue can be
> improved.
>
> 1) A short comment in the following part explaining why do we partition
> by % would clarify it for non-IPv6 experts
>
> +                except netaddr.AddrFormatError:
> <<<
> +                    addr = str(addr).partition('%')[0]
> +                    addr = netaddr.IPAddress(addr, flags=self.netaddr_ip_flags)
> +                    if addr.version != 6:
>
> 2) Patch comment can be improved as well
>
> Thanks,
> Martin
>

Updated patch attached.

Honza

-- 
Jan Cholasta
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-70.1-ipv6-zone-index.patch
Type: text/x-patch
Size: 2543 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120327/a3ba47d1/attachment.bin>