[Freeipa-devel] [PATCH] 70 Parse zone indices in IPv6 addresses in CheckedIPAddress

[Martin Kosek]

On Tue, 2012-03-27 at 11:50 +0200, Jan Cholasta wrote:
> On 27.3.2012 10:43, Martin Kosek wrote:
> > On Mon, 2012-03-19 at 14:02 +0100, Jan Cholasta wrote:
> >> https://fedorahosted.org/freeipa/ticket/2138
> >>
> >> Honza
> >>
> >
> > This will work, I just think that a documentation of this issue can be
> > improved.
> >
> > 1) A short comment in the following part explaining why do we partition
> > by % would clarify it for non-IPv6 experts
> >
> > +                except netaddr.AddrFormatError:
> > <<<
> > +                    addr = str(addr).partition('%')[0]
> > +                    addr = netaddr.IPAddress(addr, flags=self.netaddr_ip_flags)
> > +                    if addr.version != 6:
> >
> > 2) Patch comment can be improved as well
> >
> > Thanks,
> > Martin
> >
> 
> Updated patch attached.
> 
> Honza
> 

ACK. Pushed to master, ipa-2-2.

Martin