[Freeipa-devel] [PATCH] 0020 Handle missing /etc/ipa in ipa-client-install

Martin Kosek mkosek at redhat.com
Mon Apr 22 06:16:58 UTC 2013


On 04/19/2013 04:58 PM, Rob Crittenden wrote:
> Ana Krivokapic wrote:
>> On 04/19/2013 03:58 PM, Rob Crittenden wrote:
>>> Rob Crittenden wrote:
>>>> Ana Krivokapic wrote:
>>>>> Hello,
>>>>>
>>>>> Make sure /etc/ipa is created and owned by freeipa-python package.
>>>>>
>>>>> Report correct error to user if /etc/ipa is missing during client
>>>>> installation.
>>>>>
>>>>> https://fedorahosted.org/freeipa/ticket/3551
>>>>
>>>> The server also owns this directory. It should only be owned by the
>>>> python subpackage.
>>>>
>>>> %dir %{_sysconfdir}/ipa
>>>>
>>>> rob
>>>
>>> The mode should probably be 0755.
>>>
>>> rob
>>>
>>
>> Thanks, fixed.
>>
> 
> ACK. pushed to master and ipa-3-1
> 
> rob
> 

Hm, the spec change does not look right to me:

+%dir %attr(0755,root,apache) %config(noreplace) %{_sysconfdir}/ipa/

Why is the directory owned by group apache? Why does the directory have
"%config(noreplace)" set? Isn't it a NOOP when set for a directory (just asking)?

This is what we get when we install freeipa-python now:

# rm -r /etc/ipa/
# rpm -Uvh --force
/home/mkosek/dist-master/rpms/freeipa-client-3.2.0GIT2a8f1b0-0.fc18.x86_64.rpm
/home/mkosek/dist-master/rpms/freeipa-python-3.2.0GIT2a8f1b0-0.fc18.x86_64.rpm

# ll -d /etc/ipa/
drwxr-xr-x. 2 root apache 4096 Apr 22 02:05 /etc/ipa/
                   ^^^^^^
Thanks,
Martin




More information about the Freeipa-devel mailing list