[Freeipa-devel] [PATCH] 0020 Handle missing /etc/ipa in ipa-client-install

[Ana Krivokapic]

On 04/22/2013 08:16 AM, Martin Kosek wrote:
> On 04/19/2013 04:58 PM, Rob Crittenden wrote:
>> Ana Krivokapic wrote:
>>> On 04/19/2013 03:58 PM, Rob Crittenden wrote:
>>>> Rob Crittenden wrote:
>>>>> Ana Krivokapic wrote:
>>>>>> Hello,
>>>>>>
>>>>>> Make sure /etc/ipa is created and owned by freeipa-python package.
>>>>>>
>>>>>> Report correct error to user if /etc/ipa is missing during client
>>>>>> installation.
>>>>>>
>>>>>> https://fedorahosted.org/freeipa/ticket/3551
>>>>> The server also owns this directory. It should only be owned by the
>>>>> python subpackage.
>>>>>
>>>>> %dir %{_sysconfdir}/ipa
>>>>>
>>>>> rob
>>>> The mode should probably be 0755.
>>>>
>>>> rob
>>>>
>>> Thanks, fixed.
>>>
>> ACK. pushed to master and ipa-3-1
>>
>> rob
>>
> Hm, the spec change does not look right to me:
>
> +%dir %attr(0755,root,apache) %config(noreplace) %{_sysconfdir}/ipa/
>
> Why is the directory owned by group apache? Why does the directory have
> "%config(noreplace)" set? Isn't it a NOOP when set for a directory (just asking)?
>
> This is what we get when we install freeipa-python now:
>
> # rm -r /etc/ipa/
> # rpm -Uvh --force
> /home/mkosek/dist-master/rpms/freeipa-client-3.2.0GIT2a8f1b0-0.fc18.x86_64.rpm
> /home/mkosek/dist-master/rpms/freeipa-python-3.2.0GIT2a8f1b0-0.fc18.x86_64.rpm
>
> # ll -d /etc/ipa/
> drwxr-xr-x. 2 root apache 4096 Apr 22 02:05 /etc/ipa/
>                    ^^^^^^
> Thanks,
> Martin

You are right, it was a mistake on my part. Attached is a oneliner fix.

-- 
Regards,

Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-akrivoka-0021-Fix-the-spec-file.patch
Type: text/x-patch
Size: 972 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130422/7f710591/attachment.bin>