[Freeipa-devel] [PATCH] 0026 Do not display success message on failure in web UI
pvoborni at redhat.com
Mon May 13 14:51:16 UTC 2013
On 05/07/2013 05:16 PM, Ana Krivokapic wrote:
1) The change from on_success to on_error is causing problems when some
command in a batch doesn't fail. Ie.: disable multiple users on user
search facet. Disabling already disabled user causes an error. The
dialog is shown but the page is not refreshed so the newly disabled
records are still displayed as enabled. We might even call this case a
IMO we shouldn't change the method because the batch itself succeeded.
The problem should be fixed on caller side (users of batch command).
2) Also `ajax` context should be left there instead of `this`, otherwise
it would get the context of on_ok handler:
3) (not an actual issue) Some of my old code doesn't contain space
between for/if and opening curly bracet, opposite to the rest of the Web
UI. Spaces should be added when touching these parts of code.
More information about the Freeipa-devel