[Freeipa-devel] [PATCH] 0026 Do not display success message on failure in web UI

[Ana Krivokapic]

On 05/13/2013 04:51 PM, Petr Vobornik wrote:
> On 05/07/2013 05:16 PM, Ana Krivokapic wrote:
>> https://fedorahosted.org/freeipa/ticket/3591
>>
>
> 1) The change from on_success to on_error is causing problems when
> some command in a batch doesn't fail. Ie.: disable multiple users on
> user search facet. Disabling already disabled user causes an error.
> The dialog is shown but the page is not refreshed so the newly
> disabled records are still displayed as enabled. We might even call
> this case a success.
>
> IMO we shouldn't change the method because the batch itself succeeded.
> The problem should be fixed on caller side (users of batch command).
>
> 2) Also `ajax` context should be left there instead of `this`,
> otherwise it would get the context of on_ok handler:
>
> 3) (not an actual issue) Some of my old code doesn't contain space
> between for/if and opening curly bracet, opposite to the rest of the
> Web UI. Spaces should be added when touching these parts of code.

Since the problem occurs in the case when the batch succeeds, but some
commands from the batch fail, it should be enough to modify the message
that is displayed. I modified it so it shows exactly how many items from
the batch succeeded.

Updated patch is attached.

-- 
Regards,

Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-akrivoka-0026-02-Do-not-display-success-message-on-failure-in-web-UI.patch
Type: text/x-patch
Size: 2850 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130515/67c3a9c8/attachment.bin>