[Freeipa-devel] [PATCH] 736-740 webui: various minor fixes

[Endi Sukma Dewata]

On 8/5/2014 6:43 AM, Petr Vobornik wrote:
> [PATCH] 736 webui: convert widget.less indentation to spaces

ACK.

> [PATCH] 737 webui: improve rule table css
>
> - category radio line has line-height large enough to contain
>   undo button -> content doesn't move several pixels on change
> - remove vertical padding from btns in table headers to maintain
>   about the same height
> - remove invisible border from link buttons to have the same height
>   for disabled and enabled button

ACK.

> [PATCH] 738 webui: sshkey widget - usability fixes
>
> - save one click by opening edit dialog right after adding new row
> - add margin between fingerprint and "show/edit" button
> - fix honoring of writable/read-only flags upon row creation

ACK. Possible improvements:

1. How about removing the row if the user cancels the addition or enters 
blank value? That way the rows will always have values, so we don't need 
the "New: key set/not set" labels anymore.

2. Can the UI parse the new key and display it the same way as other 
keys that are already saved? That will make it more seamless.

3. If we do #2, the "Show/Set key" button probably can be changed to 
Edit or Modify.

> [PATCH] 739 webui: disable batch action buttons by default
>
> action buttons associated with batch actions were enabled by default, 
> but they were disabled right after facet creation and a load of data. 
> It caused a visual flicker.
>
> UX is enhanced by making them disabled by default.

ACK.

> [PATCH] 740 webui: fix group type padding

ACK.

-- 
Endi S. Dewata