[Freeipa-devel] [PATCH] 736-740 webui: various minor fixes

[Petr Vobornik]

On 13.8.2014 17:20, Endi Sukma Dewata wrote:
> On 8/5/2014 6:43 AM, Petr Vobornik wrote:
>> [PATCH] 736 webui: convert widget.less indentation to spaces
>
> ACK.
>
>> [PATCH] 737 webui: improve rule table css
>>
>> - category radio line has line-height large enough to contain
>>   undo button -> content doesn't move several pixels on change
>> - remove vertical padding from btns in table headers to maintain
>>   about the same height
>> - remove invisible border from link buttons to have the same height
>>   for disabled and enabled button
>
> ACK.
>
>> [PATCH] 738 webui: sshkey widget - usability fixes
>>
>> - save one click by opening edit dialog right after adding new row
>> - add margin between fingerprint and "show/edit" button
>> - fix honoring of writable/read-only flags upon row creation
>
> ACK. Possible improvements:
>
> 1. How about removing the row if the user cancels the addition or enters
> blank value? That way the rows will always have values, so we don't need
> the "New: key set/not set" labels anymore.

Good idea.

>
> 2. Can the UI parse the new key and display it the same way as other
> keys that are already saved? That will make it more seamless.

Would be nice, but is it worth the effort? We would have to reimplement 
ipapython.ssh into JavaScript + pull in crypto.js or other lib for sha1 
and sha256 functions since Web Cryptography API is still only a draft [1].


[1] https://dvcs.w3.org/hg/webcrypto-api/raw-file/tip/spec/Overview.html

>
> 3. If we do #2, the "Show/Set key" button probably can be changed to
> Edit or Modify.
>
>> [PATCH] 739 webui: disable batch action buttons by default
>>
>> action buttons associated with batch actions were enabled by default,
>> but they were disabled right after facet creation and a load of data.
>> It caused a visual flicker.
>>
>> UX is enhanced by making them disabled by default.
>
> ACK.
>
>> [PATCH] 740 webui: fix group type padding
>
> ACK.
>

Pushed to:

ipa-4-1:
* 500db900e578bc87bb95fef53ac8abff9ca47e4b webui: convert widget.less 
indentation to spaces
* 189f6fdfd539486cf49e114cf5d0ebf9fb6bee6e webui: improve rule table css
* a8a799822c4f1f3b17ac2b86ef8cf84a4a781d9e webui: sshkey widget - 
usability fixes
* dd45278e5aeb4fbb4b7f567ee6e6dda079afb728 webui: disable batch action 
buttons by default
* 2752f8e286074c210d3229ae94871afbfdc99f7f webui: fix group type padding
master:
* 8f73bf3713da42bfe6503ef2afbe4a6de3bf44d0 webui: convert widget.less 
indentation to spaces
* 356059e07ddb492aa9d6b63ee806ae804afbec40 webui: improve rule table css
* d138b44480dfef3220e0a39bef9c064a314ee6bf webui: sshkey widget - 
usability fixes
* 9446c4c8b4bc397c6c2d1d94725f7aae4b123b5f webui: disable batch action 
buttons by default
* 981b399c4e6938b4ab096dee9411cb025e221703 webui: fix group type padding

-- 
Petr Vobornik