[Freeipa-devel] [Patch] 0001-2 User Life Cycle: create containers and scoping DS plugins

[thierry bordaz]

On 08/18/2014 05:10 PM, Petr Viktorin wrote:
> On 08/18/2014 05:03 PM, thierry bordaz wrote:
>> On 08/18/2014 04:06 PM, Petr Viktorin wrote:
>>> On 08/14/2014 07:18 PM, thierry bordaz wrote:
>>>> Hello,
>>>>
>>>>     Following Petr remarks from the previous review, I modified the
>>>>     original fix to move it only in '.update' files.
>>>>
>>>>     Thanks
>>>>     thierry
>>>>
>>>
>>> Looks better, thanks!
>>> I've tested install and upgrades, everything works as expected.
>> :-) . Thanks for your tests.
>>>
>>>
>>> Some whitespace issues:
>>>
>>> Applying: User Life Cycle: create containers and scoping DS plugins
>>> .git/rebase-apply/patch:44: new blank line at EOF.
>>> +
>>> .git/rebase-apply/patch:111: new blank line at EOF.
>>> +
>>> warning: 2 lines add whitespace errors.
>>>
>>>
>>> A tiny nitpick:
>>> +dn: cn=Deleted users,cn=accounts,cn=provisioning,$SUFFIX
>>>
>>> CN is case-insensitive, but the capital D does stand out.
>>
>> Good ! This extra lines sounds a familiar issue to me ;). I fixed this
>> and I removed the extra lines and lowercase.
>> Basically it creates a new patch
>> freeipa-tbordaz-0001-3-User-Life-Cycle-new-containers-and-DS-plugin-scope.patch. 
>>
>>
>> How should I proceed here, send a new review on freeipa-devel and/or
>> attache this patch (1.3) to the bug ?
>
> Simply reply to this mail with the revised patch attached.
>
> As for attaching patches to the tickets, I've never done it and no one 
> ever complained, so it's not necessary. But attach it if you like :)

Good to know :). Thanks
>
>>> Otherwise ACK. We want to push this together with your patch 0002, 
>>> right?
>> Well, patch 0002 does not require 0001 (and the opposite as well).
>> Although they are both related to ULC, I separated them to make reviews
>> and dev simpler.
>> So if you are ok, I can push 0001 without the immediate need to push 
>> 0002.
>
> OK
>
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbordaz-0001-3-User-Life-Cycle-new-containers-and-DS-plugin-scope.patch
Type: text/x-patch
Size: 6044 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140818/0b5bbd9f/attachment.bin>