[Freeipa-devel] [PATCH] 0001 pwpolicy-add: Added better error handling
Jan Cholasta
jcholast at redhat.com
Tue Sep 2 07:19:41 UTC 2014
There's some trailing whitespace on lines 22 and 29 of the patch, but
besides that ACK.
Dne 26.8.2014 v 19:26 Thorsten Scherf napsal(a):
> Thanks Jan.
>
> Find the new patch attached.
>
> Cheers,
> Thorsten
>
>
> On [Tue, 26.08.2014 18:19], Jan Cholasta wrote:
>> Hi,
>>
>> Dne 26.8.2014 v 17:53 Thorsten Scherf napsal(a):
>>> pwpolicy-add: Added better error handling
>>> Make error message more meaningful when a password policy is added
>>> for a non
>>> existing group.
>>> https://fedorahosted.org/freeipa/ticket/4334
>>
>> thanks for the patch.
>>
>> Instead of raising NotFound manually, please use:
>>
>> self.api.Object.group.handle_not_found(keys[-1])
>>
>> It raises NotFound as well, but automatically creates the error message.
>>
>> Honza
>>
>> --
>> Jan Cholasta
>
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel
>
--
Jan Cholasta
More information about the Freeipa-devel
mailing list