[Freeipa-devel] [PATCH] 0001 pwpolicy-add: Added better error handling

[Martin Kosek]

Thanks to both!

Pushed to master: a2eab057d4adfaa8da7fee07410e1a33efb7f95d

Martin

On 09/02/2014 09:19 AM, Jan Cholasta wrote:
> There's some trailing whitespace on lines 22 and 29 of the patch, but besides
> that ACK.
> 
> Dne 26.8.2014 v 19:26 Thorsten Scherf napsal(a):
>> Thanks Jan.
>>
>> Find the new patch attached.
>>
>> Cheers,
>> Thorsten
>>
>>
>> On [Tue, 26.08.2014 18:19], Jan Cholasta wrote:
>>> Hi,
>>>
>>> Dne 26.8.2014 v 17:53 Thorsten Scherf napsal(a):
>>>> pwpolicy-add: Added better error handling
>>>>    Make error message more meaningful when a password policy is added
>>>> for a non
>>>>    existing group.
>>>>    https://fedorahosted.org/freeipa/ticket/4334
>>>
>>> thanks for the patch.
>>>
>>> Instead of raising NotFound manually, please use:
>>>
>>>    self.api.Object.group.handle_not_found(keys[-1])
>>>
>>> It raises NotFound as well, but automatically creates the error message.
>>>
>>> Honza
>>>
>>> -- 
>>> Jan Cholasta
>>
>>
>> _______________________________________________
>> Freeipa-devel mailing list
>> Freeipa-devel at redhat.com
>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>>
> 
>