[Freeipa-devel] [PATCH 0061] Ensure ipaUserAuthTypeClass when needed on user creation

Petr Vobornik pvoborni at redhat.com
Tue Sep 2 11:49:08 UTC 2014


On 28.8.2014 20:14, Nathaniel McCallum wrote:
> On Tue, 2014-08-19 at 16:46 -0400, Nathaniel McCallum wrote:
>> Also, remove the attempt to load the objectClasses when absent. This
>> never makes sense during an add operation.
>>
>> https://fedorahosted.org/freeipa/ticket/4455
>
> I still need a review for this. We are trying to get this in 4.0.2.
>
> Nathaniel
>

ACK if comment below doesn't need any change:

Maybe I'm missing something, but why do we do following check: `if 
'objectclass' in entry_attrs:`? Shouldn't it be always True? Since
the objectclass is set in LDAPCreate.execute. A pre-callback in an third 
party plugin can remove it, but I don't think we should care.
-- 
Petr Vobornik




More information about the Freeipa-devel mailing list