[Freeipa-devel] [PATCH 0061] Ensure ipaUserAuthTypeClass when needed on user creation

[Nathaniel McCallum]

On Tue, 2014-09-02 at 13:49 +0200, Petr Vobornik wrote:
> On 28.8.2014 20:14, Nathaniel McCallum wrote:
> > On Tue, 2014-08-19 at 16:46 -0400, Nathaniel McCallum wrote:
> >> Also, remove the attempt to load the objectClasses when absent. This
> >> never makes sense during an add operation.
> >>
> >> https://fedorahosted.org/freeipa/ticket/4455
> >
> > I still need a review for this. We are trying to get this in 4.0.2.
> >
> > Nathaniel
> >
> 
> ACK if comment below doesn't need any change:
> 
> Maybe I'm missing something, but why do we do following check: `if 
> 'objectclass' in entry_attrs:`? Shouldn't it be always True? Since
> the objectclass is set in LDAPCreate.execute. A pre-callback in an third 
> party plugin can remove it, but I don't think we should care.

I also thought that was odd, but I cargo-culted it to retain backwards
compatibility. Attached is a version of the patch which doesn't retain
this. I don't care which gets merged.

Nathaniel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-npmccallum-0061.1-Ensure-ipaUserAuthTypeClass-when-needed-on-user-crea.patch
Type: text/x-patch
Size: 2443 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140902/0513db92/attachment.bin>