[Freeipa-devel] [PATCH] 0011 Allow user to force Kerberos realm during installation

[Jan Cholasta]

Hi,

Dne 27.8.2014 v 13:56 David Kupka napsal(a):
> Usually it isn't wise to allow something like this. But in environment
> with broken DNS (described in ticket) there is probably not many
> alternatives.
>
> https://fedorahosted.org/freeipa/ticket/4444

1) I think you can log realm in search() as part of the "Starting IPA 
discovery ..." message instead of a separate message.


2) Also, no need to log the realm twice in search().


3) It looks like you forgot to un-indent some code in ipadnssearchkrbkdc().


Honza

-- 
Jan Cholasta