[Freeipa-devel] [PATCH] 0011 Allow user to force Kerberos realm during installation

[David Kupka]

On 09/03/2014 05:09 PM, Jan Cholasta wrote:
> Hi,
>
> Dne 27.8.2014 v 13:56 David Kupka napsal(a):
>> Usually it isn't wise to allow something like this. But in environment
>> with broken DNS (described in ticket) there is probably not many
>> alternatives.
>>
>> https://fedorahosted.org/freeipa/ticket/4444
>
> 1) I think you can log realm in search() as part of the "Starting IPA
> discovery ..." message instead of a separate message.
>
>
> 2) Also, no need to log the realm twice in search().
I forget to remove some redundant debug prints.
>
>
> 3) It looks like you forgot to un-indent some code in ipadnssearchkrbkdc().
>
Fixed, thanks.
>
> Honza
>

-- 
David Kupka
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-dkupka-0011-2-Allow-user-to-force-Kerberos-realm-during-installati.patch
Type: text/x-patch
Size: 4511 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140904/465f6c96/attachment.bin>