[Freeipa-devel] [PATCH] 0645 ipa-replica-prepare: Wait for the DNS entry to be resolvable

Martin Kosek mkosek at redhat.com
Mon Sep 22 08:38:36 UTC 2014


On 09/22/2014 10:31 AM, Petr Spacek wrote:
> On 22.9.2014 10:14, Martin Kosek wrote:
>> On 09/19/2014 07:29 PM, Petr Viktorin wrote:
>>> https://fedorahosted.org/freeipa/ticket/4551
>>>
>>> See ticket & commit message for details.
>>
>> Shouldn't we add a 1 sec sleep between tries? Wouldn't current version just
>> hammer DNS server with as many DNS queries as it can send?
> 
> Oh yes, please add some time.sleep() call :-)
> 
> Also I would like to see more detailed message:
> +        self.log.info('Waiting for hostname %s to be resolvable',
> +                      self.replica_fqdn)
> 
> => 'Waiting for hostname %s to be resolvable to A or AAAA record'

<bikeshed>

Really? Shouldn't term "resolvable" already have that covered? A good software
should work on all network types, whether it is IPv4, IPv6 or IPv8. So I
personally do not think we need to be that specific and can stick to original
proposal.

Martin




More information about the Freeipa-devel mailing list