[Freeipa-devel] [PATCH] 0645 ipa-replica-prepare: Wait for the DNS entry to be resolvable

Petr Spacek pspacek at redhat.com
Mon Sep 22 11:48:03 UTC 2014


On 22.9.2014 10:38, Martin Kosek wrote:
> On 09/22/2014 10:31 AM, Petr Spacek wrote:
>> On 22.9.2014 10:14, Martin Kosek wrote:
>>> On 09/19/2014 07:29 PM, Petr Viktorin wrote:
>>>> https://fedorahosted.org/freeipa/ticket/4551
>>>>
>>>> See ticket & commit message for details.
>>>
>>> Shouldn't we add a 1 sec sleep between tries? Wouldn't current version just
>>> hammer DNS server with as many DNS queries as it can send?
>>
>> Oh yes, please add some time.sleep() call :-)
>>
>> Also I would like to see more detailed message:
>> +        self.log.info('Waiting for hostname %s to be resolvable',
>> +                      self.replica_fqdn)
>>
>> => 'Waiting for hostname %s to be resolvable to A or AAAA record'
>
> <bikeshed>
>
> Really? Shouldn't term "resolvable" already have that covered? A good software
> should work on all network types, whether it is IPv4, IPv6 or IPv8. So I
> personally do not think we need to be that specific and can stick to original
> proposal.

I will agree with you if you post magic code which will work with DNS records 
for IPv8 :-) The code is not going to work with IPv8 just because we didn't 
mention 'A/AAAA' in the error message, A and AAAA RRtypes are hardcoded in the 
code.

My point is that user should see what exactly IPA wants and thus exactly why 
it failed.

Imagine that IPv8 is deployed and IPv8 addresses are stored in new RR type 
AAAAAAAA. Now somebody is installing/upgrading an old IPA installation and it 
gets stuck on 'Waiting for hostname %s to be resolvable' message.

So he runs 'host new-replica.ipa.test.' command and it will return an IPv8 
address. And here is the WTF moment: 'The message tells me that the name 
should be resolvable, it *is* resolvable but it still doesn't work!'

This is exactly the problem I would like to address in ticket
"[RFE] Make DNS error messages more clear - say exactly what is wrong"
https://fedorahosted.org/freeipa/ticket/3298

-- 
Petr^2 Spacek




More information about the Freeipa-devel mailing list