[Freeipa-devel] [PATCH] 0645 ipa-replica-prepare: Wait for the DNS entry to be resolvable

[Petr Viktorin]

On 09/22/2014 01:48 PM, Petr Spacek wrote:
> On 22.9.2014 10:38, Martin Kosek wrote:
>> On 09/22/2014 10:31 AM, Petr Spacek wrote:
>>> On 22.9.2014 10:14, Martin Kosek wrote:
>>>> On 09/19/2014 07:29 PM, Petr Viktorin wrote:
>>>>> https://fedorahosted.org/freeipa/ticket/4551
>>>>>
>>>>> See ticket & commit message for details.
>>>>
>>>> Shouldn't we add a 1 sec sleep between tries? Wouldn't current
>>>> version just
>>>> hammer DNS server with as many DNS queries as it can send?
>>>
>>> Oh yes, please add some time.sleep() call :-)

Wow, no idea how that slipped out. Thanks for the catch.

>>> Also I would like to see more detailed message:
>>> +        self.log.info('Waiting for hostname %s to be resolvable',
>>> +                      self.replica_fqdn)
>>>
>>> => 'Waiting for hostname %s to be resolvable to A or AAAA record'
>>
>> <bikeshed>
>>
>> Really? Shouldn't term "resolvable" already have that covered? A good
>> software
>> should work on all network types, whether it is IPv4, IPv6 or IPv8. So I
>> personally do not think we need to be that specific and can stick to
>> original
>> proposal.
>
> I will agree with you if you post magic code which will work with DNS
> records for IPv8 :-) The code is not going to work with IPv8 just
> because we didn't mention 'A/AAAA' in the error message, A and AAAA
> RRtypes are hardcoded in the code.

+1; we're checking A and AAAA so that's what we should say we're doing.

Is this wording OK?


-- 
Petr³

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0645.2-ipa-replica-prepare-Wait-for-the-DNS-entry-to-be-res.patch
Type: text/x-patch
Size: 3687 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140922/b66b68ab/attachment.bin>