[Freeipa-devel] [PATCHES] 0264-0267 backup, restore: Don't overwrite /etc/{passwd, group}

[Tomas Babej]

On 08/26/2014 01:16 PM, Petr Viktorin wrote:
> On 07/30/2014 04:26 PM, Petr Viktorin wrote:
>> On 07/29/2014 06:03 PM, Petr Viktorin wrote:
>>> On 07/29/2014 05:02 PM, Petr Viktorin wrote:
>>>> Hello,
>>>>
>>>> The first patch here consolidates our system user creation code a bit.
>>>>
>>>> The second patch fixes an oversight in the restore script.
>>>>
>>>> The third changes the backup script to not include
>>>> /etc/{passwd,group},
>>>> and the restore script to create the PKI user if a CA is being
>>>> restored.
>>>> Note that the DS user is already created early in the restore process.
>>>> (In the future we may want a nice generic framework for restoring
>>>> users,
>>>> but I'd like to extrapolate from more than one data point when
>>>> designing
>>>> it.)
>>>
>>> Another note: tar uses owner user/group names by default, so no
>>> additional chowning is required even if the IDs change between backup &
>>> restore.
>>>
>>>>
>>>> The fourth patch adds a log entry I find very useful in testing
>>>> backup/restore.
>>
>>
>> Rebased onto current master.
>
> Rebased again.
>
>
>
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel

I like the approach, solves the issue quite neatly. I didn't find any
issues in the changes themselves, or during the testing, so ACK from me
for the whole patcheset (which means patches 624-627, despite the subject).

-- 
Tomas Babej
Associate Software Engineer | Red Hat | Identity Management
RHCE | Brno Site | IRC: tbabej | freeipa.org 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140923/b6566a75/attachment.htm>