[Freeipa-devel] [PATCHES] 0631-0632 Integration tests for backup & restore

[Tomas Babej]

On 08/06/2014 04:52 PM, Petr Viktorin wrote:
> On 08/06/2014 04:36 PM, Petr Viktorin wrote:
>> Hello,
>> These patches add integration tests for backup & restore.
>
> They depend on my earlier backup/restore patches, 0624-0627.
>
>> I'm also attaching a patch for the job definitions at
>> https://github.com/encukou/freeipa-ci
>
>
> I hit Send too soon, sorry for that
>
>

Thank you for these patches, the tests themselves seem all right to me.

My only objection is that I don't think that the coverage for the basic
backup-restore test is exhaustive enough. Right now we only check the
presence of the admin entry in the LDAP via raw ldap calls and CLI, and
the output of the cert-find command.

In the future, I'd like this to be extended with basic functionality
tests for each of the services, i.e. does DNS work after the restore?
Are all the services up and running?

However, this does not block the patches, I think they can be pushed now
(this means a ACK from me) in their current form and extended later. If
you agree, I can file a ticket.

-- 
Tomas Babej
Associate Software Engineer | Red Hat | Identity Management
RHCE | Brno Site | IRC: tbabej | freeipa.org