[Freeipa-devel] [PATCHES] 0631-0632 Integration tests for backup & restore

[Petr Viktorin]

On 09/23/2014 12:17 PM, Tomas Babej wrote:
>
> On 08/06/2014 04:52 PM, Petr Viktorin wrote:
>> On 08/06/2014 04:36 PM, Petr Viktorin wrote:
>>> Hello,
>>> These patches add integration tests for backup & restore.
>>
>> They depend on my earlier backup/restore patches, 0624-0627.
>>
>>> I'm also attaching a patch for the job definitions at
>>> https://github.com/encukou/freeipa-ci
>>
>>
>> I hit Send too soon, sorry for that
>>
>>
>
> Thank you for these patches, the tests themselves seem all right to me.
>
> My only objection is that I don't think that the coverage for the basic
> backup-restore test is exhaustive enough. Right now we only check the
> presence of the admin entry in the LDAP via raw ldap calls and CLI, and
> the output of the cert-find command.
>
> In the future, I'd like this to be extended with basic functionality
> tests for each of the services, i.e. does DNS work after the restore?
> Are all the services up and running?
>
> However, this does not block the patches, I think they can be pushed now
> (this means a ACK from me) in their current form and extended later. If
> you agree, I can file a ticket.

Thanks for the review. Pushed to:
master: ccb91f5970537df6362ec7f41cded369b668e91a
ipa-4-1: 5fc92d621b73afba4bf240b2e35f9160bfac0c44


You're right, this does need more tests.
I'll get to writing more tests. I think we can just keep the ticket open 
for now.


-- 
Petr³