[Freeipa-devel] [PATCH] 0001 Refactor selinuxenabled check

Petr Viktorin pviktori at redhat.com
Fri Sep 26 13:41:18 UTC 2014


Hello! Thanks for the patch!

The new function is not one of the platform-independent tasks, and 
doesn't even use `self`, so you can define it as a module-level helper 
function.

But more importantly, this won't work: the blocks you are replacing 
return from their functions. You'd need to use something like:
     if not selinux_enabled():
         return
instead of:
     self.check_enabled_selinux()

-- 
Petr³




More information about the Freeipa-devel mailing list