[Freeipa-devel] [PATCH] 0001 Refactor selinuxenabled check

[Francesco Marella]

On 26/09/2014 15:41, Petr Viktorin wrote:
>
> Hello! Thanks for the patch!
>
> The new function is not one of the platform-independent tasks, and 
> doesn't even use `self`, so you can define it as a module-level helper 
> function.
>
> But more importantly, this won't work: the blocks you are replacing 
> return from their functions. You'd need to use something like:
>     if not selinux_enabled():
>         return
> instead of:
>     self.check_enabled_selinux()
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-fmarella-0001-2-Refactor-selinuxenabled-check.patch
Type: text/x-patch
Size: 2931 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140926/404c28a9/attachment.bin>