[Freeipa-devel] [PATCH] 0017 Do not require description in UI.

David Kupka dkupka at redhat.com
Mon Sep 29 09:04:28 UTC 2014


On 09/29/2014 10:22 AM, Martin Kosek wrote:
> On 09/29/2014 10:09 AM, David Kupka wrote:
>> https://fedorahosted.org/freeipa/ticket/4387
>
> The changes look OK so far, except the test fix.
>
> The test_batch_plugin.py test is apparently testing that batch command behaves
> well in RequirementError for options. Thus, we should not remove it, we should
> just pick different option. Like filling uid+first options with user-add, but
> missing the --last option.
>
> Martin
>

Ok, but the test is bit redundant as there is already test for missing 
givenname that should behave the same way.

-- 
David Kupka
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-dkupka-0017-2-Do-not-require-description-in-UI.patch
Type: text/x-patch
Size: 12116 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140929/78939943/attachment.bin>


More information about the Freeipa-devel mailing list