[Freeipa-devel] [PATCH] 0017 Do not require description in UI.

[Martin Kosek]

On 09/29/2014 11:04 AM, David Kupka wrote:
> On 09/29/2014 10:22 AM, Martin Kosek wrote:
>> On 09/29/2014 10:09 AM, David Kupka wrote:
>>> https://fedorahosted.org/freeipa/ticket/4387
>>
>> The changes look OK so far, except the test fix.
>>
>> The test_batch_plugin.py test is apparently testing that batch command behaves
>> well in RequirementError for options. Thus, we should not remove it, we should
>> just pick different option. Like filling uid+first options with user-add, but
>> missing the --last option.
>>
>> Martin
>>
> 
> Ok, but the test is bit redundant as there is already test for missing
> givenname that should behave the same way.

I think it is useful to keep the test here, in the previous one no option was
added.

Anyway, this should not stop this patch from going in. I checked the test
results + Web UI and all looks OK.

ACK. Pushed to:
master: cd9a4cca1fe17998a342fde000ece5bf46d13d27
ipa-4-1: b69510b9bf8216d52707968bf520fd2dfa6e1ba7

Thanks,
Martin