[Freeipa-devel] [PATCH] 0078-82: webui tests: tests for new certificate widget

[Martin Basti]

On 01.08.2016 16:13, Lenka Doudova wrote:
>
>
>
> On 07/29/2016 03:00 PM, Pavel Vomacka wrote:
>>
>>
>>
>> On 07/28/2016 08:16 AM, Lenka Doudova wrote:
>>>
>>>
>>>
>>> On 07/20/2016 04:51 PM, Pavel Vomacka wrote:
>>>> Please review attached patches, which add tests for new certificate 
>>>> widget in WebUI.
>>>>
>>>> https://fedorahosted.org/freeipa/ticket/6064
>>>>
>>>>
>>>>
>>> Hi,
>>> thanks for patches.
>>> Functionally ok, but you have lots of PEP8 errors in patches 78, 80, 
>>> 81 and 82 -> NACK.
>>> Also in patch 82, method test_arbitrary_certificate, comment says 
>>> user needs to have "arbitrary_cert" configured, but the property in 
>>> config file is correctly "arbitrary_cert_path", so it's a bit 
>>> misleading.
>>>
>>> Patch 79 is OK, ACK.
>>>
>>> Lenka
>>>
>>>
>> Thank you for review. Attaching patches which have fixed all pep8 
>> erros. Bad property of config file was also mentioned in patch 81. 
>> These are also fixed.
>>
>> -- 
>> Pavel^3 Vomacka
> Hi,
>
> all is fine now, ACK for all patches.
>
> Lenka
>
>
master:
* 26803a0d173192ee05878dd47c22a95b4432d078 Add possibility to choose 
parent element by css
* 45825b84b0d140f62e1459c3b5dbb5281229cad6 Add function which check 
whether the field is empty
* 37c0bd1dd6e19dd4afefb47ab52ace0a25f2ca82 TEST: managing user certificates
* 20e8cef394993855fb291cb55684fe3facad82aa TEST: managing host certificates
* 5f5203eb620d21244d3c39ee25ba8f093106122b TEST: managing service 
certificates

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160801/6465c5c8/attachment.htm>