[Freeipa-devel] [PATCH] 0004 Added support for authentication with user certificate

[Tibor Dudlak]

Hi,

I have edited my previous patch.

On Thu, Aug 11, 2016 at 11:52 AM, Jan Cholasta <jcholast at redhat.com> wrote:

> Hi,
>
> On 11.8.2016 09:55, Tibor Dudlak wrote:
>
>> Hi,
>>
>> ...
>>
>
> +class login_x509(login_kerberos, KerberosSession, HTTP_Status):
> +    key = '/session/login_x509'
>
> login_kerberos already subclasses KerberosSession and HTTP_Status, no need
> to do it again here. In fact, it would be best to split off the bussiness
> logic from login_kerberos into a separate class and inherit both
> login_kerberos and login_x509 from it:
>
>     class KerberosLogin(Backend, KerberosSession, HTTP_Status):
>         def _on_finalize(self):
>             ...
>
>         def __call__(self, ...):
>             ...
>
>     class login_kerberos(KerberosLogin):
>         key = '/session/login_kerberos'
>
>     class login_x509(KerberosLogin):
>         key = '/session/login_x509'
>
> Honza
>
> --
> Jan Cholasta
>

Thank jcholast for review, it should be all right now.

-- 
Tibor Dudlák
Intern - Identity management Special Projects
Red Hat
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160812/59d4e277/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tdudlak-0004-Added-support-for-authentication-with-user-certificate.patch
Type: text/x-patch
Size: 11134 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160812/59d4e277/attachment.bin>