[Freeipa-devel] [PATCH] 0003 Validate key in otptoken-add

[Martin Basti]

On 16.08.2016 17:35, Tomas Krizek wrote:
> Hi,
>
> the attached patch fixes an error message when user provides an empty 
> key while adding otp token.
>
> https://fedorahosted.org/freeipa/ticket/6200
>
>
>

I'm curious why we don't fix it here:

         OTPTokenKey('ipatokenotpkey?',
             cli_name='key',
             label=_('Key'),
             doc=_('Token secret (Base32; default: random)'),
             default_from=lambda: os.urandom(KEY_LENGTH),
             autofill=True,
             flags=('no_display', 'no_update', 'no_search'),
         ),


If OTPTokenKey is mandratory, it should be required param (autofill 
should work in this case too)

Martin^2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160819/d1f0a9ed/attachment.htm>