[Freeipa-devel] [PATCH] 0003 Validate key in otptoken-add

[Tomas Krizek]

Seems like a good idea, I'm attaching the updated patch. Autofill does 
work when the param is required.


On 08/19/2016 04:19 PM, Martin Basti wrote:
>
>
>
> On 16.08.2016 17:35, Tomas Krizek wrote:
>> Hi,
>>
>> the attached patch fixes an error message when user provides an empty 
>> key while adding otp token.
>>
>> https://fedorahosted.org/freeipa/ticket/6200
>>
>>
>>
>
> I'm curious why we don't fix it here:
>
>         OTPTokenKey('ipatokenotpkey?',
>             cli_name='key',
>             label=_('Key'),
>             doc=_('Token secret (Base32; default: random)'),
>             default_from=lambda: os.urandom(KEY_LENGTH),
>             autofill=True,
>             flags=('no_display', 'no_update', 'no_search'),
>         ),
>
>
> If OTPTokenKey is mandratory, it should be required param (autofill 
> should work in this case too)
>
> Martin^2

-- 
Tomas Krizek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160822/7d510304/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tkrizek-0003-2-Validate-key-in-otptoken-add.patch
Type: text/x-patch
Size: 1038 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160822/7d510304/attachment.bin>