[Freeipa-devel] [PATCH] 0078-82: webui tests: tests for new certificate widget

[Pavel Vomacka]

On 07/28/2016 08:16 AM, Lenka Doudova wrote:
>
>
>
> On 07/20/2016 04:51 PM, Pavel Vomacka wrote:
>> Please review attached patches, which add tests for new certificate 
>> widget in WebUI.
>>
>> https://fedorahosted.org/freeipa/ticket/6064
>>
>>
>>
> Hi,
> thanks for patches.
> Functionally ok, but you have lots of PEP8 errors in patches 78, 80, 
> 81 and 82 -> NACK.
> Also in patch 82, method test_arbitrary_certificate, comment says user 
> needs to have "arbitrary_cert" configured, but the property in config 
> file is correctly "arbitrary_cert_path", so it's a bit misleading.
>
> Patch 79 is OK, ACK.
>
> Lenka
>
>
Thank you for review. Attaching patches which have fixed all pep8 erros. 
Bad property of config file was also mentioned in patch 81. These are 
also fixed.

-- 
Pavel^3 Vomacka

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160729/2146ee61/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvomacka-0078-2-Add-possibility-to-choose-parent-element-by-css.patch
Type: text/x-patch
Size: 3947 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160729/2146ee61/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvomacka-0079-Add-function-which-check-whether-the-field-is-empty.patch
Type: text/x-patch
Size: 1214 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160729/2146ee61/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvomacka-0080-2-TEST-managing-user-certificates.patch
Type: text/x-patch
Size: 5295 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160729/2146ee61/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvomacka-0081-2-TEST-managing-host-certificates.patch
Type: text/x-patch
Size: 8623 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160729/2146ee61/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvomacka-0082-2-TEST-managing-service-certificates.patch
Type: text/x-patch
Size: 9113 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160729/2146ee61/attachment-0004.bin>