[Freeipa-devel] [freeipa PR#268][comment] Build system must regenerate file when template changes

pspacek freeipa-github-notification at redhat.com
Fri Nov 25 12:31:06 UTC 2016


  URL: https://github.com/freeipa/freeipa/pull/268
Title: #268: Build system must regenerate file when template changes

pspacek commented:
"""
I already described problems with `AC_CONFIG_FILE` in https://github.com/freeipa/freeipa/pull/251#issuecomment-261470338 a week ago, including envisioned move from `AC_CONFIG_FILE` to `Makefile.am`.

Please propose a solution which does not have problems mentioned in https://github.com/freeipa/freeipa/pull/251#issuecomment-261470338 so we can consider it.


For the record, this sed replacement is nothing unusual. The sed replacement is what [Autoconf v2.69 manual chapter 4.8.2 Installation Directory Variables](https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Installation-Directory-Variables.html) recommends and is already used all over the place in the build system (init directory, daemons/ipa-otpd, and elsewhere).

It is pitty that you did not comment on envisioned direction a week ago, nor a three days ago when first version of this PR was published.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/268#issuecomment-262948252


More information about the Freeipa-devel mailing list