[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [K12OSN] ldm login and password that starts with '@'



Sounds like you'd best file a bug upstream with LTSP.

https://bugs.launchpad.net/ltsp

Kindest regards,

Jan Middelkoop
Recreatie en Zorg Groep B.V.

--
Website: http://www.recreatie-zorg.nl/
E-mail: jan recreatie-zorg nl
Telefoon: +31 10 714 22 97


Op 01-03-12 03:19, Norman Gaywood schreef:
Just found an interesting bug in ldm. If you type @ as the first
character of the password, the enter key does not work.

The password of @guest@ or @backend@ will allow the enter key to work
again but the login screen will just go back to the user prompt.

This of course will stop people having @ as the first character of their
password.

Here is the code from ldmgreetercomm.c that I think is going wrong:

int listen_greeter(gchar **buffer, gsize *buflen, gsize *end) {
     while (1) {
         /* Reads data from I/O channel of the greeter */
         GError *ge = NULL;
         if(g_io_channel_read_line(greeterr, buffer, buflen, end,&ge) != G_IO_STATUS_NORMAL) {
             log_entry("ldm",3,"%s", ge->message);
             return 1;
         }

         g_strstrip(*buffer);
         log_entry("ldm",7,"Got command: %s",*buffer);

         /* handle callbacks */
         if (**buffer == '@') {
             if (!g_strncasecmp(*buffer, "@backend@", 9)) {
                 ldm_raise_auth_except(AUTH_EXC_RELOAD_BACKEND);
             } else if (!g_strncasecmp(*buffer, "@guest@", 7)) {
                 ldm_raise_auth_except(AUTH_EXC_GUEST);
             }
             continue;
         }
         break;
     }
     return 0;
}


I think that continue should not be there.




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]