[katello-devel] Merging and Pulling with no wait

[Jason Rist]

On Tue 23 Oct 2012 12:12:27 PM MDT, Bryan Kearney wrote:
> On 10/23/2012 11:24 AM, Jason Rist wrote:
>> Hi Everyone - I started a discussion on IRC because I can't just walk
>> over to people's cubes and question things, but I thought an email would
>> be best to expand the conversation.
>>
>> This morning I was going through my emails and I saw two emails for pull
>> request 898. ( https://github.com/Katello/katello/pull/898 ).  One for
>> the pull request and 12 minutes later an ACK and merge.  Unless I'm
>> checking my email all the time, I would have missed that.  And I did
>> miss it.
>>
>> Now I'm picking on one pull request but the fact of the matter is that
>> this has happened a bunch lately.
>>
>> The whole point of the pull request process is to make sure we're
>> getting a chance to prevent errors like the one that pull request #903
>> was made to fix.
>>
>> Eric pointed out that there isn't a specified wait time but can we
>> please take into consideration that 12 minutes isn't enough for a pull
>> request to be fully discussed?
>
> What is enought time? Keep in mind that for +5 hours of each day, the
> other half of the team is not there.
> -- bk
>


Then doesn't it have to be at least +5 hours?

-J

--
Jason E. Rist
Senior Software Engineer
Systems Management and Cloud Enablement
Red Hat, Inc.
+1.919.754.4048
Freenode: jrist
github/identi.ca: knowncitizen