[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 0/6] generator: Split up generator/actions.ml



On Saturday, 18 February 2017 12:54:35 CET Richard W.M. Jones wrote:
> Split up the huge generator/actions.ml into several smaller files.

Few notes:

- regarding patch #2: wasn't the order stable before? Except from the
  explicitly seen order change in tests_c_api.ml, what made the actions
  order non-deterministic?

- regarding patch #5: download_inode should be in actions_tsk.ml

- regarding patch #5: I'm personally not fond of the _deprecated.ml
  versions: that means in case an API is deprecated, then it is moved
  from one place to another, IMHO for no reason.
  +1 for the split, -1 for the _deprecated split

Thanks,
-- 
Pino Toscano

Attachment: signature.asc
Description: This is a digitally signed message part.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]