[Libguestfs] [virt-v2v wave 2 PATCH v2 04/16] output: handle Standard_VGA in the JSON format

Laszlo Ersek lersek at redhat.com
Thu Dec 2 09:46:25 UTC 2021


The JSON output mode was added in commit fba6a498d472 ("v2v: add -o json
output mode", 2019-04-01). The format that it uses is by convention (aka
"ad-hoc"); not governed by any public specification. Map the Standard_VGA
value of "guestcaps.gcaps_video" to the "vga" string, as this is (a)
straightforward and (b) consistent with the OpenStack and libvirt device
model names.

Cc: Fabian Deutsch <fdeutsch at redhat.com>
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1961107
Signed-off-by: Laszlo Ersek <lersek at redhat.com>
---

Notes:
    v2:
    
    - tested by Ming Xie <mxie at redhat.com> from RH QE meanwhile
      <https://bugzilla.redhat.com/show_bug.cgi?id=1961107#c28>
    
    v1:
    
    - new in v1

 output/create_json.ml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/output/create_json.ml b/output/create_json.ml
index 3cadf6b43378..ac044630a0c6 100644
--- a/output/create_json.ml
+++ b/output/create_json.ml
@@ -203,7 +203,7 @@ let create_json_metadata source inspect
       | RTL8139 -> "rtl8139" in
     let video =
       match guestcaps.gcaps_video with
-      | Standard_VGA -> assert false
+      | Standard_VGA -> "vga"
       | QXL -> "qxl"
       | Cirrus -> "cirrus" in
     let machine =
-- 
2.19.1.3.g30247aa5d201




More information about the Libguestfs mailing list