[Libguestfs] [virt-v2v wave 2 PATCH v2 05/16] convert_linux: flip target display to Standard_VGA

Laszlo Ersek lersek at redhat.com
Thu Dec 2 09:46:26 UTC 2021


Policy change: pick Standard_VGA over QXL for the video type in the output
(Linux) domain, always.

For Standard_VGA, use the "modesetting" X.org driver.

(In a Fedora 34 guest using standard VGA video, and having no explicit
X.org config file, the X.org server logs the following (excerpt):

> Markers: (--) probed, (**) from config file, (==) default setting,
>         (++) from command line, (!!) notice, (II) informational,
>         (WW) warning, (EE) error, (NI) not implemented, (??) unknown.
> (==) Matched modesetting as autoconfigured driver 0
> (==) Matched fbdev as autoconfigured driver 1
> (==) Matched vesa as autoconfigured driver 2
> (II) LoadModule: "modesetting"
> (II) Loading /usr/lib64/xorg/modules/drivers/modesetting_drv.so
> (II) LoadModule: "fbdev"
> (II) Loading /usr/lib64/xorg/modules/drivers/fbdev_drv.so
> (II) LoadModule: "vesa"
> (II) Loading /usr/lib64/xorg/modules/drivers/vesa_drv.so
> (II) Loading sub module "fbdevhw"
> (II) LoadModule: "fbdevhw"
> (II) Loading /usr/lib64/xorg/modules/libfbdevhw.so
> (II) UnloadModule: "fbdev"
> (II) Unloading fbdev
> (II) UnloadSubModule: "fbdevhw"
> (II) Unloading fbdevhw
> (II) UnloadModule: "vesa"
> (II) Unloading vesa

This tells us that the standard VGA device model is driven by the
"modesetting" driver.)

Cc: Gerd Hoffmann <kraxel at redhat.com>
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1961107
Acked-by: Gerd Hoffmann <kraxel at redhat.com>
Signed-off-by: Laszlo Ersek <lersek at redhat.com>
---

Notes:
    v1:
    
    - reimplement the following RFC patches, taken together:
    
      - convert_linux: use "modesetting" X.org driver for Standard_VGA
      - convert_linux: flip default target display to Standard_VGA
    
      due to commit b28cd1dcfeb4 ("Remove requested_guestcaps / rcaps",
      2021-11-08) [Rich]
    
    - pick up Gerd's ACK for choosing the "modesetting" X.org driver.

 convert/convert_linux.ml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/convert/convert_linux.ml b/convert/convert_linux.ml
index 41bc4218e948..f0213f06eec2 100644
--- a/convert/convert_linux.ml
+++ b/convert/convert_linux.ml
@@ -148,7 +148,7 @@ let convert (g : G.guestfs) source inspect keep_serial_console _ =
     let guestcaps = {
       gcaps_block_bus = block_type;
       gcaps_net_bus = net_type;
-      gcaps_video = QXL;
+      gcaps_video = Standard_VGA;
       gcaps_virtio_rng = kernel.ki_supports_virtio_rng;
       gcaps_virtio_balloon = kernel.ki_supports_virtio_balloon;
       gcaps_isa_pvpanic = kernel.ki_supports_isa_pvpanic;
@@ -819,7 +819,7 @@ let convert (g : G.guestfs) source inspect keep_serial_console _ =
       true
 
   and configure_display_driver () =
-    let video_driver = "qxl" in
+    let video_driver = "modesetting" in
 
     let updated = ref false in
 
-- 
2.19.1.3.g30247aa5d201




More information about the Libguestfs mailing list