[Libguestfs] [libnbd PATCH v2 4/8] python: Reformat generated methods.c in a few places
Richard W.M. Jones
rjones at redhat.com
Tue Jun 7 08:00:08 UTC 2022
On Mon, Jun 06, 2022 at 09:08:29PM -0500, Eric Blake wrote:
> + pr ":nbd_%s\",\n" name;
You could put this pr (but without the \n) ...
> + pr " ";
> + pr_wrap ',' (fun () ->
... inside pr_wrap here, and it would mean you wouldn't need to print
spaces to indent (because pr_wrap should do it for you).
It all looks sensible and equivalent to the old code, and the output
is cleaner too, so:
Reviewed-by: Richard W.M. Jones <rjones at redhat.com>
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
nbdkit - Flexible, fast NBD server with plugins
https://gitlab.com/nbdkit/nbdkit
More information about the Libguestfs
mailing list