[Libguestfs] [libnbd PATCH v2 2/8] python: Plug uninit leak in nbd.Buffer.to_bytearray

Richard W.M. Jones rjones at redhat.com
Tue Jun 7 13:13:23 UTC 2022


On Mon, Jun 06, 2022 at 09:08:27PM -0500, Eric Blake wrote:
> @@ -79,7 +80,7 @@ let
>         "aio_buffer_from_bytearray";
>         "aio_buffer_to_bytearray";
>         "aio_buffer_size";
> -       "aio_buffer_is_zero" ] @ List.map fst handle_calls);
> +       "aio_buffer_is_zero"] @ List.map fst handle_calls);
> 
>    pr "\n";
>    pr "#endif /* LIBNBD_METHODS_H */\n"
> @@ -111,7 +112,7 @@ let
>         "aio_buffer_from_bytearray";
>         "aio_buffer_to_bytearray";
>         "aio_buffer_size";
> -       "aio_buffer_is_zero" ] @ List.map fst handle_calls);
> +       "aio_buffer_is_zero"] @ List.map fst handle_calls);
>    pr "  { NULL, NULL, 0, NULL }\n";
>    pr "};\n";
>    pr "\n";

Unintended whitespace changes?  Without those two hunks:

Reviewed-by: Richard W.M. Jones <rjones at redhat.com>

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org


More information about the Libguestfs mailing list