[Libguestfs] [libnbd PATCH v2 2/8] python: Plug uninit leak in nbd.Buffer.to_bytearray
Eric Blake
eblake at redhat.com
Tue Jun 7 13:32:17 UTC 2022
On Tue, Jun 07, 2022 at 02:13:23PM +0100, Richard W.M. Jones wrote:
> On Mon, Jun 06, 2022 at 09:08:27PM -0500, Eric Blake wrote:
> > @@ -79,7 +80,7 @@ let
> > "aio_buffer_from_bytearray";
> > "aio_buffer_to_bytearray";
> > "aio_buffer_size";
> > - "aio_buffer_is_zero" ] @ List.map fst handle_calls);
> > + "aio_buffer_is_zero"] @ List.map fst handle_calls);
> >
> > pr "\n";
> > pr "#endif /* LIBNBD_METHODS_H */\n"
> > @@ -111,7 +112,7 @@ let
> > "aio_buffer_from_bytearray";
> > "aio_buffer_to_bytearray";
> > "aio_buffer_size";
> > - "aio_buffer_is_zero" ] @ List.map fst handle_calls);
> > + "aio_buffer_is_zero"] @ List.map fst handle_calls);
> > pr " { NULL, NULL, 0, NULL }\n";
> > pr "};\n";
> > pr "\n";
>
> Unintended whitespace changes? Without those two hunks:
Yeah, I was playing with adding aio_buffer_is_init to let the user
probe the status of an nbd.Buffer, then changed my mind, and it shows.
Will fix.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
More information about the Libguestfs
mailing list