[Libvir] [PATCH] Check ReadOnly-flag

[Richard W.M. Jones]

S.Sakamoto wrote:
> Hi
> 
> When a general user uses command "# virsh --connect xen start domain",
> don't become an error, and domain start.
> Because ReadOnly-flag is not "1" when a general user uses it.
> 
> So, here's the patch adds to check ReadOnly-flag.
> 
> 
> Signed-off-by: Shigeki Sakamoto <fj0588di at aa.jp.fujitsu.com>
> 
> 
> Thanks,
> Shigeki Sakamoto.
> 
> 
> 
> Index: src/libvirt.c
> ===================================================================
> RCS file: /data/cvs/libvirt/src/libvirt.c,v
> retrieving revision 1.66
> diff -u -p -r1.66 libvirt.c
> --- src/libvirt.c	4 Apr 2007 14:19:49 -0000	1.66
> +++ src/libvirt.c	12 Apr 2007 07:55:32 -0000
> @@ -301,6 +301,10 @@ do_open (const char *name, int flags)
>              break;
>          }
>      }
> +    
> +    if (flags & VIR_DRV_OPEN_RO) {
> +        ret->flags = VIR_CONNECT_RO;
> +    }
>  
>      return ret;
>  

Yes, that's quite a serious bug introduced with the Xen unified patch. 
I've committed your fix.

Thanks,

Rich.

-- 
Emerging Technologies, Red Hat  http://et.redhat.com/~rjones/
64 Baker Street, London, W1U 7DF     Mobile: +44 7866 314 421

Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.
Registered in England and Wales under Company Registration No. 3798903
Directors: Michael Cunningham (USA), Charlie Peters (USA) and David
Owens (Ireland)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070412/7ecf2cb5/attachment-0001.bin>