[Libvir] big-endian support for libvirt - introduce GUEST_HANDLE infrastructure ?
Christian Ehrhardt
ehrhardt at linux.vnet.ibm.com
Wed Jul 11 12:11:38 UTC 2007
> That would be perfect ! Maybe we don't even need to hook in configure
> I'm sure endianness info can come from standard headers, then combined
> with a processor check that should be sufficient I guess.
>
Without introducing all the guest handle infrastructure and by just
fixing the known xen_v2s3_getdomaininfolistop and xen_v2d5_cpumap the
patch became as nice and small as a patch should be ;-)
The Libvirt padding is now handled by using gcc's __BIG_ENDIAN__, no
configure/header/... needed that way. I think we can assume that at
least when libvirt is compiled for ppc gcc is used right?
I used one (1) really generic line from our ppc libxc code, this should
be no licencing issue (LGPL vs. GPL). Tell me if someone think otherwise
and I'll try to change it a bit.
Since it is no longer a macro we could pre-calculate the sizes anyway,
but the way it is now says clearly "64bit size - used size" for the
padding and I like that kind of readability.
--
Grüsse / regards,
Christian Ehrhardt
IBM Linux Technology Center, Open Virtualization
+49 7031/16-3385
Ehrhardt at linux.vnet.ibm.com
Ehrhardt at de.ibm.com
IBM Deutschland Entwicklung GmbH
Vorsitzender des Aufsichtsrats: Johann Weihen
Geschäftsführung: Herbert Kircher
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libvirt_endianess.diff
Type: text/x-patch
Size: 1192 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070711/27871320/attachment-0001.bin>
More information about the libvir-list
mailing list