[Libvir] [PATCH] Fix string handling in virDomain{Get, Set}SchedulerParameters

Richard W.M. Jones rjones at redhat.com
Fri Jun 22 10:03:45 UTC 2007

Jim Meyering wrote:
> "Richard W.M. Jones" <rjones at redhat.com> wrote:
>> This small patch fixes some bugs in the handling of the field string
>> in virDomainGetSchedulerParameters and makes a similar pre-emptive fix
>> to virDomainSetSchedulerParameters.
>> Also, please don't use !strcmp(a,b), because it confuses me.  Better
>> is to write strcmp(a,b) == 0 to mean "strings match" and strcmp(a,b)
>> != 0 to mean "strings don't match".
> Hi Rich,
> I agree, but prefer to avoid direct use of strcmp altogether.
> I use this definition:
>   #define STREQ(a, b) (strcmp (a, b) == 0)
> Then all uses are either
>    STREQ(a, b) or
>  ! STREQ(a, b)

Let's try this updated patch.


Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libvirt-xen-sched-strings-20070622-2.patch
Type: text/x-patch
Size: 2957 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070622/ace61ccc/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070622/ace61ccc/attachment-0003.bin>

More information about the libvir-list mailing list