[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: Allow specific FDs to be kept open in virExec()

On Tue, Aug 26, 2008 at 10:41:18AM +0100, Daniel P. Berrange wrote:
> On Thu, Aug 21, 2008 at 02:58:30PM +0100, Daniel P. Berrange wrote:
> > With my recent patches to virExec(), all FDs except stdin/out/err are closed
> > before the child is exec'd to prevent accidental leaks. Of course I forgot
> > the one key place where we need to propagate FDs... The TAP devices passed
> > to QEMU.
> > 
> > This patch adds a 'keepfd' parameter to virExec() which allows the caller
> > to specify a bitset of file descriptors to keep open, and updates the 
> > callers to use this as required. The QEMU driver specifies any TAP fds
> > and the LXC driver specifies its PTY this way removing a previous hack.
> > 
> > QEMU networking works again with fix....
> Changed to use fd_set from sys/select

Yup, +1.


Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
Read my OCaml programming blog: http://camltastic.blogspot.com/
Fedora now supports 64 OCaml packages (the OPEN alternative to F#)

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]