[Libvir] [PATCH] Clean up the global name space.
Daniel P. Berrange
berrange at redhat.com
Mon Jan 14 13:53:34 UTC 2008
On Mon, Jan 14, 2008 at 12:33:56PM +0000, Richard W.M. Jones wrote:
> Jim Meyering wrote:
> >After mentioning "avoid global variables" as a potential
> >addition to HACKING, I did some quick tests and spotted
> >a few that are easy to eliminate. This is useful even
> >if we don't end up automating the check:
> > Clean up the global name space.
> > * src/qemu_conf.c: Add "static" and "const" attributes to some
> > globals.
> > * src/qemu_conf.h: Update a declaration.
> > * src/qemu_driver.c (qemud_driver): Declare static.
> These structures were originally shared between files, but lots of code
> refactoring since seems to make that obsolete.
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
More information about the libvir-list